Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: database encryption and google group rbac for autopilot #1265

Merged
merged 4 commits into from
May 24, 2022
Merged

feat: database encryption and google group rbac for autopilot #1265

merged 4 commits into from
May 24, 2022

Conversation

jmymy
Copy link
Contributor

@jmymy jmymy commented May 20, 2022 •
edited
Loading

Fix for #1233 and #1232

@jmymy jmymy marked this pull request as ready for review May 20, 2022 14:32
@jmymy jmymy requested review from a team, Jberlinsky and bharathkkb as code owners May 20, 2022 14:32
@comment-bot-dev
Copy link

Thanks for the PR! 🚀
✅ Lint checks have passed.

bharathkkb
bharathkkb approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jmymy

@bharathkkb bharathkkb merged commit 066149d into terraform-google-modules:master May 24, 2022
@release-please release-please bot mentioned this pull request May 24, 2022
Merged
@jmymy jmymy deleted the improvements branch May 24, 2022 18:47
This was referenced Jun 21, 2022
Closed
Closed
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@jmymy
feat: support database encryption and google group rbac for autopilot (…
922a437 
…terraform-google-modules#1265)

* feat: database encryption and google rbac for autopilot

* chore: cleanup ordering

* chore: cleanup ordering vars

* chore: more cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmymy @comment-bot-dev @bharathkkb