Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set only one of log/mon config or service #1240

Merged
merged 4 commits into from
May 3, 2022
Merged

Conversation

bharathkkb
Copy link
Member

API only permits either logging/monitoring_service or logging/monitoring_config. Also added a test.

fixes #1144

@bharathkkb bharathkkb requested review from a team and Jberlinsky as code owners May 3, 2022 00:13
@comment-bot-dev
Copy link

comment-bot-dev commented May 3, 2022

Thanks for the PR! 🚀
✅ Lint checks have passed.

@morgante morgante merged commit 2316e77 into master May 3, 2022
@bharathkkb bharathkkb deleted the fix-log-mon branch May 4, 2022 15:48
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…les#1240)

* fix: set only one of log/mon config or service

* regen

* add test

* remove for autopilot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants