Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create new node pool when shielded_instance_config changes #1237

Merged
merged 5 commits into from
Jul 11, 2022
Merged

fix: Create new node pool when shielded_instance_config changes #1237

merged 5 commits into from
Jul 11, 2022

Conversation

abursavich
Copy link
Contributor

Fixes #923

This adds the enable_secure_boot and enable_integrity_monitoring properties from the shielded_instance_config to the list that triggers the creation of a new node pool.

Example:

...

      ~ node_config {
          ~ shielded_instance_config {
              ~ enable_secure_boot          = false -> true # forces replacement
                # (1 unchanged attribute hidden)
            }
        }

...

│ Error: resource - projects/xxx/locations/us-west1/clusters/xxx/nodePools/xxx-00de - already exists
│ 
│   with module.gke.google_container_node_pool.pools["xxx"],
│   on .terraform/modules/gke/modules/beta-private-cluster-update-variant/cluster.tf line 448, in resource "google_container_node_pool" "pools":
│  448: resource "google_container_node_pool" "pools" {
│ 

See: ForceNew at https://github.com/hashicorp/terraform-provider-google/blob/v4.19.0/google/node_config.go#L208-L233

@abursavich abursavich requested review from a team, Jberlinsky and bharathkkb as code owners April 27, 2022 23:45
@abursavich
Copy link
Contributor Author

I can't view any details of the kubernetes-engine-int-trigger failure?

@comment-bot-dev
Copy link

@abursavich
Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @abursavich

@bharathkkb bharathkkb merged commit a2272f0 into terraform-google-modules:master Jul 11, 2022
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling secure boot on an existing nodepool is failing
4 participants