-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TPG>=5.43)!: replacing "no_age" -> "send_age_if_zero" #340
fix(TPG>=5.43)!: replacing "no_age" -> "send_age_if_zero" #340
Conversation
The documentation warns about the removal of this "no_age" param. However, the code is not reflecting that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @jjnunogarcia!
Can you please bump the minimum provider to v5.43.0 as that is required for this change: https://github.com/terraform-google-modules/terraform-google-cloud-storage/blob/master/modules/simple_bucket/versions.tf#L23
/gcbrun |
@apeabody Done :) |
Thanks @jjnunogarcia! As you are adding the |
Oh gosh, I missed that @apeabody |
/gcbrun |
The documentation warns about the removal of this
no_age
param with the newsend_age_if_zero
. However, the code is not reflecting that.