Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add name and url outputs on simple_bucket module #175

Merged
merged 1 commit into from
Jul 13, 2022
Merged

feat: add name and url outputs on simple_bucket module #175

merged 1 commit into from
Jul 13, 2022

Conversation

jbpaux
Copy link
Contributor

@jbpaux jbpaux commented Jun 9, 2022

Hi,

It would be nice to have the same outputs as the "multi cloud storage" module:

  • Name of the storage account (to ensure dependency composition with main module or other modules)
  • URL of the bucket

@google-cla
Copy link

google-cla bot commented Jun 9, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@apeabody
Copy link
Contributor

/gcbrun

@comment-bot-dev
Copy link

@jbpaux
Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @jbpaux for the contribution!

@apeabody apeabody changed the title Add name and url outputs on simple_bucket module feat: add name and url outputs on simple_bucket module Jul 13, 2022
@apeabody apeabody merged commit d76ffa3 into terraform-google-modules:master Jul 13, 2022
@jbpaux jbpaux deleted the feat/simple-bucket-outputs branch July 14, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants