Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The set-output command is deprecated and will be disabled soon #97

Closed
gtazzoli-uala opened this issue Nov 14, 2022 · 27 comments · May be fixed by #121
Closed

The set-output command is deprecated and will be disabled soon #97

gtazzoli-uala opened this issue Nov 14, 2022 · 27 comments · May be fixed by #121
Labels
bug Something isn't working

Comments

@gtazzoli-uala
Copy link

Describe the bug

When running from @v1.0.0 or main I get:

Warning: The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see:

How can we reproduce it?

  - name: Update README.md docs
    id: update-readme
    uses: terraform-docs/gh-actions@main #or v1.0.0 
    with:
      working-dir: .
      output-file: README.md
      output-method: inject
      git-push: "true"
      config-file: './.config/.terraform-docs.yml'
@gtazzoli-uala gtazzoli-uala added the bug Something isn't working label Nov 14, 2022
@gtazzoli-uala gtazzoli-uala changed the title Node.js 12 actions are deprecated The set-output command is deprecated and will be disabled soon Nov 14, 2022
@lbeltramino
Copy link

I'm having the same issue. Hope this is fixed soon.

@cordobacancun
Copy link

Same Here! Hope this is fixed soon.

@charly942
Copy link

I still have the same problem too, hope this is fixed soon.

@jhegert-infraDevOps
Copy link

Experiencing the same issue. Hope they fix this soon!

@GonzaloRodriguezCabrera
Copy link

I'm having the same issue. Hope this is fixed soon.

@heuerluis
Copy link

Hi all, I´ve got the same problem. Thanks so much for showing this issue. Fixing it will be great for me too.

@jvidelaolmos
Copy link

I'm facing the same issue here.

@gomeznf
Copy link

gomeznf commented Dec 1, 2022

Hi, I'm having the same issue here. Hope this is fixed soon. Thanks in advance.

@db4rr3t0
Copy link

db4rr3t0 commented Dec 1, 2022

I'm having the same issue here.

@katanita
Copy link

katanita commented Dec 1, 2022

I'm facing the same issue here. Hope it gets fixed soon.

@nicolascavedale
Copy link

I'm having the same issue! Please fix this.

@jonathanio
Copy link

There is a commit (18dc76d) with the fix in main, but there is no release with this change. Getting a v1.0.1 release out would be great!

I think in the meantime you can use the following override:

    - name: Render terraform docs inside the README.md and push changes back to PR branch
      uses: terraform-docs/gh-actions@18dc76d9b2e3c746cf6f8e073c7fa7df16dcf620
      with:
        ...

@ipc-zpg
Copy link

ipc-zpg commented Dec 2, 2022

even with this:

       - name: Render terraform docs and push changes back to PR
         uses: terraform-docs/gh-actions@18dc76d9b2e3c746cf6f8e073c7fa7df16dcf620
         with:
           working-dir: ./liftshift_terraform/
           output-file: README.md
           output-method: inject
           git-push: "true"

I am getting:

<!-- END_TF_DOCS --> ./liftshift_terraform/
liftshift_terraform/README.md updated successfully
::debug No change in ./liftshift_terraform// detected
Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
::debug No files changed, skipping commit

@gtazzoli-uala
Copy link
Author

Hello,

Just an update. From @main still the same.
What I did was to create my own Docker image using the Dockerfile that was updated on recent commits and pulled that image to my own public repository. Then I forked this repo and updated the action.yml with the new image and the warnings have gone.
They need to build and pull a new image and update the action.yml on this repo to make it work. Until that we have to wait or make our own.

Cheers!
Gus.

@chrisdleech-pol
Copy link

Hello,

Just an update. From @main still the same. What I did was to create my own Docker image using the Dockerfile that was updated on recent commits and pulled that image to my own public repository. Then I forked this repo and updated the action.yml with the new image and the warnings have gone. They need to build and pull a new image and update the action.yml on this repo to make it work. Until that we have to wait or make our own.

Cheers! Gus.

Thanks for the tip, it worked for me. I had to add the following to the Dockerfile to get it to build though: https://www.alpinelinux.org/posts/Alpine-edge-signing-keys-rotated.html

@marcofranssen
Copy link

marcofranssen commented Feb 16, 2023

Could we get a release containing the fix mentioned above?

git tag -sam "This release adds …" v1.0.1
git push origin v1.0.1

@MitchellPaff
Copy link

A release containing this fix would be appreciated soon. We are approaching May31st with an average speed of 24hrs per day.

@marcofranssen
Copy link

@khos2ow are you able to help. I have seen you have been one of the most active committers here, so hoping you are a maintainer who can cut a release.

@arogic
Copy link

arogic commented Apr 25, 2023

Can we have an ETA? Thanks in advance.

@marcofranssen
Copy link

@metmajer are you able to help cutting a release?

@gonzaatcroud
Copy link

@metmajer @khos2ow appreciate the help if possible, I'd hate to have to remove the action from our workflows given it's been working so well.

@bahag-hammera
Copy link

Are there any news on this topic?

@Samsanga
Copy link

GitHub is monitoring telemetry for the usage of these save-state and set-output and plan to fully disable them on 31st May 2023. Starting 1st June 2023 workflows using save-state or set-output commands via stdout will fail with an error.

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Please try to address this asap

@mcantinqc
Copy link

I check this issue and the fix is already in the main branch, #94, but there are no new version since the fix.

The codeowner (@khos2ow ) need to release a new version and update the docker version on that line https://github.com/terraform-docs/gh-actions/blob/main/action.yml#L88.

@MarkRoss-Eviden
Copy link

Any update on this, is this repo and action still being managed?

@marcofranssen
Copy link

marcofranssen commented Oct 3, 2023

@metmajer @khos2ow is this repo still maintained? Are you looking for maintainers? Would be great to get some updates on this action.

I'm also happy to contribute the fixes required, just want to confirm the fixes are going to be merged and released.

@khos2ow
Copy link
Member

khos2ow commented Mar 23, 2024

This is now released and available in v1.1.0. Sorry for the very long delay.

I'm going to close this and mark it as done.

@khos2ow khos2ow closed this as completed Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.