Count giving unexpected and unclear number

[Verhaeg]

Description :
Trying to write a simple count of resources created but the expected value is 615 instead of 18.

Using terraform-gsuite plugin to manage new groups and using a module to create those groups with certain people already in them. Expected to assert that all groups I created are present in the plan using the count check but the tests fail with unrealistic count.

To Reproduce

1. <Either a sample terraform code, or your terraform plan file if it doesn't have any confidential information>

provider gsuite {
    oauth_scopes = [
        "https://www.googleapis.com/auth/admin.directory.group",
        "https://www.googleapis.com/auth/admin.directory.user"
    ]
}

resource "gsuite_group" "my-group-i" {
  email       = "[email protected]"
  name        = "My Group I"
}

resource "gsuite_group" "my-group-ii" {
  email       = "[email protected]"
  name        = "My Group II"
}

2. terraform-compliance -p .plan.out --features .tests/compliance
3. python package
4. Failure: for ['module.my_team.gsuite_group.level-i', 'module.my_team.gsuite_group.level-ii', 'module.my_team.gsuite_group.level-iii', ...] on email. 615 is not equal to 18.

Scenario: Ensure I have all groups
    Given I have gsuite_group defined
    When it contains email
    And I count them
    Then its value must be equal to 2

Expected behavior :
Test should pass

Tested versions :

• terraform-compliance v1.1.12
• Terraform v0.12.24
• Python 2.7.17

Additional context
The examples I gave (the codes) are reduced since we have some internal names for this case. But should suffice.
Also, I'm currently unaware of all existing groups we have, but those are the only managed ones

[eerkunt]

Hi @Verhaeg,

It is hard to understand since this looks like a custom provider. Would it be possible post a plan.out (or plan.out.json) for debugging ?

[Verhaeg]

I had to comment out the members (not important right now) and changed the names by leaving only 3 groups created.

plan.out.txt

Sorry for not being able to leave as an example, but here is the test output for this file:

Feature: Email groups should be created with three levels and users inside

Scenario: Ensure I have all groups
    Given I have gsuite_group defined
    When it contains email
    And I count them
    Then its value must be equal to 3

$ terraform-compliance -p ./plan.out.txt --features tests/compliance
terraform-compliance v1.1.12 initiated

🚩 Features	: /Users/verhaeg/Projects/terraform-gsuit/tests/compliance
🚩 Plan File	: /Users/verhaeg/Projects/terraform-gsuit/plan.out.txt

🚩 Running tests. 🎉

Feature: Email groups should be created with three levels and users inside  # /Users/verhaeg/Projects/terraform-gsuit/tests/compliance/groups.feature

    Scenario: Ensure I have all groups
        Given I have gsuite_group defined
        When it contains email
        And I count them
			Failure: for ['module.team_myteam.gsuite_group.gcp-level-i', 'module.team_myteam.gsuite_group.gcp-level-ii', 'module.team_myteam.gsuite_group.gcp-level-iii'] on email. 81 is not equal to 3.
        Then its value must be equal to 3
          Failure:

1 features (0 passed, 1 failed)
1 scenarios (0 passed, 1 failed)
4 steps (3 passed, 1 failed)
Run 1585583094 finished within a moment

[eerkunt]

Yep, reproduced the problem with your plan output, thank you!

Having a deeper look.

[eerkunt]

Yep, found the problem. It looks like there is slight problem on the count function where we count the characters within those emails :)

Testing my fix.

[eerkunt]

Just released 1.1.14, will take few minutes to get into PyPi.

Could you please try and let me know about the result ? Thanks!

[Verhaeg]

Awesome! Tests passed now!

thanks for the quick fix

[ghost]

This issue's conversation is now locked. If you want to continue this discussion please open a new issue.