Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow creating VPC routes for already existing or shared TGW #114

Merged
merged 5 commits into from
Dec 11, 2023
Merged

feat: Allow creating VPC routes for already existing or shared TGW #114

merged 5 commits into from
Dec 11, 2023

Conversation

kamilhristov
Copy link
Contributor

@kamilhristov kamilhristov commented Jul 5, 2023 •
edited
Loading

Description

These changes allow the creation of VPC routes for already existing or shared TGWs via tgw_id that already exists without changing the input variables.

Motivation and Context

Currently, VPC routes can point only to the transit gateway created by the module itself.

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@kamilhristov kamilhristov changed the title Allow creating VPC routes for already existing or shared TGW feat: allow creating VPC routes for already existing or shared TGW Jul 5, 2023
@kamilhristov kamilhristov changed the title feat: allow creating VPC routes for already existing or shared TGW feat: Allow creating VPC routes for already existing or shared TGW Jul 5, 2023
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Aug 24, 2023
@Kostadin-Lazarov
Copy link

Given that this PR is currently blocking our production deployment, could we please move forward and merge the PR?

@github-actions github-actions bot removed the stale label Aug 26, 2023
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Sep 25, 2023
@kamilhristov
Copy link
Contributor Author

@antonbabenko ping

@github-actions github-actions bot removed the stale label Oct 3, 2023
@Kostadin-Lazarov
Copy link

@antonbabenko ping

@TLPNull
Copy link

TLPNull commented Oct 18, 2023

I am starting to use this module now, is the project dead? I am having the same issue

@jack1902
Copy link

jack1902 commented Nov 1, 2023

This would be a useful addition, but wondering what the maintenance status of this module is as it has been over 7 months since any changes have actually been made

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2023

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Dec 2, 2023
bryantbiggs
bryantbiggs approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@bryantbiggs bryantbiggs merged commit 20c4dc4 into terraform-aws-modules:master Dec 11, 2023
8 checks passed
antonbabenko pushed a commit that referenced this pull request Dec 11, 2023
@semantic-release-bot
chore(release): version 2.12.0 [skip ci]
89cd41c 
## [2.12.0](v2.11.0...v2.12.0) (2023-12-11)

### Features

* Allow creating VPC routes for already existing or shared TGW ([#114](#114)) ([20c4dc4](20c4dc4))
@antonbabenko
Copy link
Member

This PR is included in version 2.12.0 🎉

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kostadin-Lazarov Kostadin-Lazarov Kostadin-Lazarov approved these changes

@bryantbiggs bryantbiggs bryantbiggs approved these changes

@vietcgi vietcgi vietcgi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kamilhristov @Kostadin-Lazarov @TLPNull @jack1902 @antonbabenko @vietcgi @bryantbiggs