Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added tags per VPC attachment #103

Merged
merged 3 commits into from
Feb 27, 2023

Conversation

l13t
Copy link
Contributor

@l13t l13t commented Feb 27, 2023

Description

Added an option to override tags on VPC attachment level in case you need some unique tags or override VPC attachment name

Motivation and Context

I would like to have a unique name or some specific list of tags for every VPC attachment created by the module.

Breaking Changes

Not expected.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

l13t added 2 commits February 27, 2023 13:17
Added an option to override tags on VPC attachment level in case you need some unique tags or override VPC attachment name
main.tf Outdated Show resolved Hide resolved
@antonbabenko antonbabenko merged commit e4d6df2 into terraform-aws-modules:master Feb 27, 2023
antonbabenko pushed a commit that referenced this pull request Feb 27, 2023
## [2.9.0](v2.8.2...v2.9.0) (2023-02-27)

### Features

* Added tags per VPC attachment ([#103](#103)) ([e4d6df2](e4d6df2))
@antonbabenko
Copy link
Member

This PR is included in version 2.9.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants