-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terraform v0_12 module #4
Conversation
do you have an estimate when this will be merged? |
Hopefully closer to the end of this week or during weekends. |
@antonbabenko any update on this? |
very eager to start using this module, please can I get an update? |
would also be nice to have an optional create_bucket variable to enable/disable module similar to the create_vpc variable in https://github.com/terraform-aws-modules/terraform-aws-vpc |
} | ||
} | ||
|
||
dynamic "server_side_encryption_configuration" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do a terraform fmt
on this file?
Hi Ebrahim
Sorry for the late reply
I think that it won't apply to the module as it is on the "AWS vpc" module.
How are you thinking in using it?
Best regards
Bruno Amaral
…On Mon, Jul 8, 2019, 18:31 Ebrahim Moshaya ***@***.***> wrote:
would also be nice to have an optional create_bucket variable to
enable/disable module similar to the create_vpc variable in
https://github.com/terraform-aws-modules/terraform-aws-vpc
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4?email_source=notifications&email_token=ADT4LHY2YZWGDZ63LCO7J6LP6OW4JA5CNFSM4HPEUVW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZONH7Y#issuecomment-509400063>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADT4LHZ7UJCCLKJDY4IV67DP6OW4JANCNFSM4HPEUVWQ>
.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
No description provided.