fix: Added missing check for attach_access_log_delivery_policy for access logs logic

[brycewade1]

Description

This change simply adds var.attach_access_log_delivery_policy into the logic computing if the bucket policy should be attached or not.

This should address issue (#251).

Motivation and Context

Without this change if a bucket is being created solely for purpose of S3 access logs without any other bucket policy related flags the combined bucket policy will not be created nor attached to the bucket.

Breaking Changes

This should not break backwards compatibility.

How Has This Been Tested?

• I have updated at least one of the examples/* to demonstrate and validate my change(s)
• I have tested and validated these changes using one or more of the provided examples/* projects
• I have executed pre-commit run -a on my pull request

I've tested my change with code similar to this (with bucket names changed to protect the innocent):

module "access_log_bucket" {
  source                            = "[email protected]:brycewade1/terraform-aws-s3-bucket.git?ref=bugfix/attach-access-log-policy"
  bucket                            = "s3-log-bucket-${local.region}-${local.account_id}"
  attach_access_log_delivery_policy = true
}

Which produced a bucket policy similar to this:

{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "AWSAccessLogDeliveryWrite",
            "Effect": "Allow",
            "Principal": {
                "Service": "logging.s3.amazonaws.com"
            },
            "Action": "s3:PutObject",
            "Resource": "arn:aws:s3:::s3-log-bucket-us-west-2-012345678910/*"
        },
        {
            "Sid": "AWSAccessLogDeliveryAclCheck",
            "Effect": "Allow",
            "Principal": {
                "Service": "logging.s3.amazonaws.com"
            },
            "Action": "s3:GetBucketAcl",
            "Resource": "arn:aws:s3:::s3-log-bucket-us-west-2-012345678910"
        }
    ]
}

[antonbabenko]

This PR is included in version 3.15.1 🎉

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.