Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add inventory config support #192

Conversation

magreenbaum
Copy link
Member

Description

Add inventory configuration support.

Motivation and Context

https://docs.aws.amazon.com/AmazonS3/latest/userguide/storage-inventory.html

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just a few minor comments.

examples/s3-inventory/main.tf Show resolved Hide resolved
examples/s3-inventory/main.tf Outdated Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
@antonbabenko antonbabenko merged commit 8836d0f into terraform-aws-modules:master Nov 11, 2022
antonbabenko pushed a commit that referenced this pull request Nov 11, 2022
## [3.6.0](v3.5.0...v3.6.0) (2022-11-11)

### Features

* Add inventory config support ([#192](#192)) ([8836d0f](8836d0f))
@antonbabenko
Copy link
Member

This PR is included in version 3.6.0 🎉

@antonbabenko
Copy link
Member

Thank you very much for the contributions to several terraform-aws-modules, @magreenbaum !

@magreenbaum magreenbaum deleted the feat/add_inventory_config_support branch November 11, 2022 12:15
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants