fix: Remove deprecated attributes from ignore_changes #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phr3nzii
force-pushed
the
remove-warnings
branch
from
ddb8ca9 to
704b3f2
Compare
antonbabenko
changed the title
antonbabenko
pushed a commit
that referenced
this pull request
Aug 26, 2022
### [3.3.1](v3.3.0...v3.3.1) (2022-08-26) ### Bug Fixes * Remove deprecated attributes from ignore_changes ([#179](#179)) ([8366ccc](8366ccc))
|
This PR is included in version 3.3.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes deprecated attributes from the
aws_s3_bucketresource. This required a change to the required AWS provider version, version4.9.0made the removed attributes optional - this module uses the standalone resources.I also updated one of the examples as the hard-coded value caused errors when testing.
Fixes #174
Fixes #177
Fixes #176
Motivation and Context
Prior to this change, Terraform shows
Warning: Deprecated attributewhen running an apply. This no longer happens with these changes.This fixes #174 and #177
Breaking Changes
There are no breaking changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)completeexampleexamples/*projectscompleteexample was usedpre-commit run -aon my pull requestAs mentioned above, I use the
completeexample to show the behaviour before and after these changes. This example required removing a hardcoded canonical ID to get it to deploy before any changes had been made.