Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added source_hash parameter to modules/object #178

Conversation

SolidSly
Copy link
Contributor

Description

I added the source_hash parameter for the S3 bucket object.
Fixes #171

Motivation and Context

Attribute etag is not compatible with KMS encryption, so I can`t use it during update of uploaded file via terraform. Need to use attribute source_hash instead etag, but this attribute is missing in current object module.

Breaking Changes

No breaking change.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@antonbabenko antonbabenko changed the title chore: Add source_hash parameter feat: Added source_hash parameter to modules/object Aug 26, 2022
@antonbabenko antonbabenko merged commit 6cf4584 into terraform-aws-modules:master Aug 26, 2022
antonbabenko pushed a commit that referenced this pull request Aug 26, 2022
## [3.4.0](v3.3.1...v3.4.0) (2022-08-26)

### Features

* Added source_hash parameter to modules/object ([#178](#178)) ([6cf4584](6cf4584))
@antonbabenko
Copy link
Member

This PR is included in version 3.4.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
@SolidSly SolidSly deleted the chore/add-source-hash-parameter branch October 28, 2022 05:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to use attribute source_hash in object module
2 participants