fix: Allow setup eventbridge without notifications #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breitsmiley
changed the title
breitsmiley
changed the title
antonbabenko
changed the title
|
Good catch! :) |
antonbabenko
pushed a commit
that referenced
this pull request
May 18, 2022
### [3.2.1](v3.2.0...v3.2.1) (2022-05-18) ### Bug Fixes * Allow setup eventbridge without notifications ([#160](#160)) ([31b8e9d](31b8e9d))
|
This PR is included in version 3.2.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Impossible to use notification module only for enable/disable S3 EventBridge. You need to set at least one notification option.
Motivation and Context
PR allows setup eventbridge without adding notification options
Breaking Changes
No breaking changes. It was removed validation of length of arrays of notifications settings. Without this validation dynamic blocks will still not executed because of empty arrays
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request