Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added wrappers automatically generated via hook #156

Merged
merged 3 commits into from
May 4, 2022

Conversation

antonbabenko
Copy link
Member

@antonbabenko antonbabenko commented May 2, 2022

This fix should make code generation of wrappers simpler (thanks to antonbabenko/pre-commit-terraform#376).

Soon, I would like to copy it to some other modules where users often create multiple similar resources, e.g., EC2 instances, SQS, SNS, ACM, DynamoDB, ECR, IAM, Route53, Security Group (after refactoring).

@bryantbiggs How do you like my English? Should we have hcledit in your GH Action repository (clowdhaus/terraform-composite-actions/pre-commit)?

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added a ticket to track the addition - should be able to add in next day or two

@antonbabenko antonbabenko merged commit 3634462 into master May 4, 2022
@antonbabenko antonbabenko deleted the added_wrapper_module_hook branch May 4, 2022 12:30
antonbabenko pushed a commit that referenced this pull request May 4, 2022
## [3.2.0](v3.1.1...v3.2.0) (2022-05-04)

### Features

* Added wrappers automatically generated via hook ([#156](#156)) ([3634462](3634462))
@antonbabenko
Copy link
Member Author

This PR is included in version 3.2.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants