Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add lifecycle ignore changes on s3_bucket resource to prevent configuration loop #145

Merged

Conversation

jaybocc2
Copy link
Contributor

@jaybocc2 jaybocc2 commented Apr 2, 2022

add lifecycle ignore changes on s3_bucket resource to prevent configuration loop to fix #144

Description

add lifecycle ignore changes on s3_bucket resource for all new resources that are separate to prevent configuration loop

Motivation and Context

fixes lifecycle loop

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

I tested it live because this is blocking my work 😞

@jaybocc2 jaybocc2 changed the title add lifecycle ignore changes on s3_bucket resource to prevent configuration loop fix #144 - add lifecycle ignore changes on s3_bucket resource to prevent configuration loop Apr 2, 2022
@jaybocc2 jaybocc2 changed the title fix #144 - add lifecycle ignore changes on s3_bucket resource to prevent configuration loop fix: #144 - add lifecycle ignore changes on s3_bucket resource to prevent configuration loop Apr 2, 2022
@jaybocc2 jaybocc2 changed the title fix: #144 - add lifecycle ignore changes on s3_bucket resource to prevent configuration loop Fix: #144 - add lifecycle ignore changes on s3_bucket resource to prevent configuration loop Apr 2, 2022
@jaybocc2 jaybocc2 changed the title Fix: #144 - add lifecycle ignore changes on s3_bucket resource to prevent configuration loop fix: Add lifecycle ignore changes on s3_bucket resource to prevent configuration loop (#144) Apr 2, 2022
@antonbabenko
Copy link
Member

I think I was able to reproduce the bug you described in #144, and this PR resolves it.

A message saying Note: Objects have changed outside of Terraform can be misleading for many users, but it is another issue with the Terraform core.

I have also added acl and versioning to ignore_changes just in case.

Merging and releasing now. Thank you!

@antonbabenko antonbabenko changed the title fix: Add lifecycle ignore changes on s3_bucket resource to prevent configuration loop (#144) fix: Add lifecycle ignore changes on s3_bucket resource to prevent configuration loop Apr 2, 2022
@antonbabenko antonbabenko merged commit 895cfa5 into terraform-aws-modules:master Apr 2, 2022
antonbabenko pushed a commit that referenced this pull request Apr 2, 2022
### [3.0.1](v3.0.0...v3.0.1) (2022-04-02)

### Bug Fixes

* Add lifecycle ignore changes on s3_bucket resource to prevent configuration loop ([#145](#145)) ([895cfa5](895cfa5))
@antonbabenko
Copy link
Member

This PR is included in version 3.0.1 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants