Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Update to support AWS provider v3.75 and newer (including v4.x) #139

Merged
merged 9 commits into from
Mar 30, 2022
Merged

feat!: Update to support AWS provider v3.75 and newer (including v4.x) #139

merged 9 commits into from
Mar 30, 2022

Conversation

antonbabenko
Copy link
Member

@antonbabenko antonbabenko commented Mar 8, 2022 •
edited
Loading

Breaking changes:

  • Yes, see file UPGRADE-3.0.md
  • Requires AWS provider v3.75 or newer (including v4.x)

Fixes #137
Closes #138

@antonbabenko antonbabenko marked this pull request as draft March 8, 2022 20:55
@wideawakening wideawakening mentioned this pull request Mar 10, 2022
Closed
@gruckion
Copy link

Is there a way for me to use this now? Rather than waiting for it to be merged? How is that done in the Terraform world. Also 👍 for making the changes.

@rblaine95
Copy link

rblaine95 commented Mar 13, 2022 •
edited
Loading

Is there a way for me to use this now? Rather than waiting for it to be merged? How is that done in the Terraform world. Also 👍 for making the changes.

It's definitely not recommended to use in anything other than testing, and is probably very highly discouraged, but you can do this:

module "s3" {
  source = "git::https://github.com/terraform-aws-modules/terraform-aws-s3-bucket.git?ref=fix-tf-provider-v4"
}

@dirnikk
Copy link

dirnikk commented Mar 15, 2022 •
edited
Loading

Thanks Anton,
I think you missed some var declaration, but overall it's work for me as expected.
One Terraform apply and in my case versioning and acl were created and anded successfully to tf state.

@rnikoopour
Copy link

HI All,

What needs to happen to get this across the finish line? I'd be happy to contribute where I can.

This module has been a great help for me and I'd like for this get completed and merged.

@Chili-Man
Copy link

hey @antonbabenko is there anything we can do to get this through the finish line?

@antonbabenko
Copy link
Member Author

Hello everyone!

I have been recovering and resumed working on this PR earlier today after some thinking about potential resolutions mentioned here (hashicorp/terraform-provider-aws#23106). One of the things I have been thinking about was how to make this module compatible with v3 AND v4 to minimize state migration for resources.

Anyway, I plan to finish this PR and have support for AWS provider v4 as soon as possible - Tuesday, 29th of March.

@antonbabenko antonbabenko mentioned this pull request Mar 26, 2022
Merged
@andrewjeffree
Copy link

in regards to state migration using moved blocks would be an easy win? no need for manual state moves by anyone? https://www.terraform.io/language/modules/develop/refactoring

vutny
vutny reviewed Mar 29, 2022
View reviewed changes
versions.tf Outdated
@@ -4,7 +4,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = "~> 3.69"
version = ">= 4.2.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = ">= 4.2.0"
version = ">= 3.75.0"

Hi @antonbabenko
Thanks for your work on this.
Actually, Hashicorp "backported" those breaking changes for S3 resources into AWS provider version 3.75.0.
So I think this is a clear way to keep the code with 3.x release unless all major modules will support 4.x in full.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will incorporate this change also. Thank you!

@antonbabenko antonbabenko mentioned this pull request Mar 29, 2022
Closed
@antonbabenko antonbabenko changed the title feat: Update to support AWS provider v4 feat!: Update to support AWS provider v3.75 and newer (including v4.x) Mar 29, 2022
@antonbabenko antonbabenko marked this pull request as ready for review March 29, 2022 19:39
@antonbabenko antonbabenko mentioned this pull request Mar 30, 2022
Closed
@antonbabenko antonbabenko merged commit e0de434 into master Mar 30, 2022
@antonbabenko antonbabenko deleted the fix-tf-provider-v4 branch March 30, 2022 13:43
antonbabenko pushed a commit that referenced this pull request Mar 30, 2022
@semantic-release-bot
chore(release): version 3.0.0 [skip ci]
1ae31ac 
## [3.0.0](v2.15.0...v3.0.0) (2022-03-30)

### ⚠ BREAKING CHANGES

* Update to support AWS provider v3.75 and newer (including v4.x) (#139)

### Features

* Update to support AWS provider v3.75 and newer (including v4.x) ([#139](#139)) ([e0de434](e0de434))
@antonbabenko
Copy link
Member Author

This PR is included in version 3.0.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vutny vutny vutny left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support terraform-provider-aws 4.x
8 participants
@antonbabenko @gruckion @rblaine95 @dirnikk @rnikoopour @Chili-Man @andrewjeffree @vutny