fix: Pin version to v3 due to number of breaking changes in v4 #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antonbabenko not sure what to do here - it looks like either terraform validate or something within pre-commit is not respecting the v3.x pin. locally running an init and plan works fine though |
|
There were several improvements (aka "potential bugs") in pre-commit-terraform during today but the fix d362eb6 was still required. Time to merge this one :) |
antonbabenko
pushed a commit
that referenced
this pull request
Feb 10, 2022
### [2.14.1](v2.14.0...v2.14.1) (2022-02-10) ### Bug Fixes * Pin version to v3 due to number of breaking changes in v4 ([#136](#136)) ([7dd9a65](7dd9a65))
|
This PR is included in version 2.14.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tomap({})Note: running pre-comit locally fails the checks. It seems like its not respecting the
~> 3.xand trying to validate against 4x which shows as a failure. However, going into the example directories and runningterraform init -upgrade=true && terraform planworks as expectedMotivation and Context
Breaking Changes
How Has This Been Tested?
examples/*projects