Support conditional creation for the database too. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good work, but adjust outputs when |
…rameter group, and subnet group. Pass them from main.tf to the nested modules.
|
@antonbabenko I believe this PR is now ready for consideration. Thank you! |
antonbabenko
added a commit
that referenced
this pull request
Jan 31, 2018
|
Thanks! Always run at least one of examples to reveal the broken parts, I have updated outputs to fix it. New release is v1.10.0. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to be able to conditionally create databases. For example, I may only want read replica databases in the staging and production environments. Lower tiered environments would not have a read replica. The count variable provides that flexibility while maintaining the DRY principle. In the absence of this variable, I have to maintain multiple, environment specific, terraform files.