-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for random password #306
feat: support for random password #306
Conversation
This comment has been minimized.
This comment has been minimized.
@bryantbiggs do we think this feature could be added to the next release? |
overall looks good - if you could update the complete examples when you get a chance, I run through a couple tests and we should be good to go |
nvm i'll add random password module to all the complete examples |
@bondezbond no no - I've added two instances to the
so if you could just add the following to both create_random_password = true
random_password_length = 16 and also add an output to the examples for |
@bryantbiggs I opted to create its own module resource to show how you can create a random password without setting password. Found a bug that way. I'm hoping thats okay to leave as is. I tested by running |
@bryantbiggs is there anything else you need for this PR? |
kk I've removed the second resource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validated with complete-postgresql
- good to go @antonbabenko 👍🏼 - thanks @bondezbond 🎉
thanks for validating! |
Thanks @bondezbond for this one! v2.32.0 has been just released. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Add support to create a random password
Motivation and Context
Rather than having the parent project create it I wanted to follow a similiar pattern that was established in terraform-aws-rds-aurora.
Breaking Changes
How Has This Been Tested?