snapshot_identifier default value causing validation conflict in aws provider 3.29

[fractos]

As of yesterday, aws provider 3.29 now has validation on whether a username and a snapshot identifier are set. This appears to be sensitive to whether null or "" is used. The default in this module is "" which busts the validation.

This is currently being tracked in hashicorp/terraform-provider-aws#17712

By way of mitigation, could we consider changing the default for snapshot_identifier to null ?

[rollue]

I can confirm this is happening in my development settings too.

[aleon1220]

is happenning to me now and i am on terraform cloud. I believe the conflict is in
the duplicate use of the var.snapshot_identifier

Take a look at line 63 and 139

https://github.com/terraform-aws-modules/terraform-aws-rds/blob/master/modules/db_instance/main.tf#L139

[aleon1220]

I think the majority of the community is tracking the issue at hashicorp/terraform-provider-aws#17712

[bryantbiggs]

hi all - can you re-check now since we have made the change to use null in #289

[evanstachowiak]

The new version fixed it for me, @bryantbiggs

[bryantbiggs]

thanks @evanstachowiak - closing this out for now but if there are any other issues, pleas feel free to open a new issue

[fractos]

@bryantbiggs Yep that's fixed it for us as well. Thanks! Well, in combination with the reversion of the AWS provider change.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.