-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add IAM role output #22
Conversation
thanks - we should have exported this from the beginning. Can we copy this https://github.com/terraform-aws-modules/terraform-aws-ecs/blob/f2befd85b08c588ab2df4b515af187d2bb70c9e2/modules/cluster/outputs.tf#L57C1-L70C2 and use it here (update to match the correct name) to ensure the standard properties for the IAM role are exported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating to include feedback on making this match the ECS module.
I have updated the PR to include role name and unique_id to match what is being done in ECS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thank you!
## [3.1.0](v3.0.0...v3.1.0) (2023-08-30) ### Features * Add IAM role output ([#22](#22)) ([d18ae45](d18ae45))
This PR is included in version 3.1.0 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Adds an output for IAM role arn and updates the README.md to reflect this new output.
Motivation and Context
This allows you to reference the role used by the module. Since the module might create a new role you don't know what the new role's ARN is unless you look it up in some other way. This makes it easy to reference.
Breaking Changes
No, it shouldn't break anything.
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request