Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add IAM role output #22

Merged
merged 5 commits into from
Aug 30, 2023
Merged

Conversation

mmclane
Copy link
Contributor

@mmclane mmclane commented Aug 10, 2023

Description

Adds an output for IAM role arn and updates the README.md to reflect this new output.

Motivation and Context

This allows you to reference the role used by the module. Since the module might create a new role you don't know what the new role's ARN is unless you look it up in some other way. This makes it easy to reference.

Breaking Changes

No, it shouldn't break anything.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@mmclane mmclane changed the title Add IAM role output feat: Add IAM role output Aug 10, 2023
@bryantbiggs
Copy link
Member

thanks - we should have exported this from the beginning. Can we copy this https://github.com/terraform-aws-modules/terraform-aws-ecs/blob/f2befd85b08c588ab2df4b515af187d2bb70c9e2/modules/cluster/outputs.tf#L57C1-L70C2 and use it here (update to match the correct name) to ensure the standard properties for the IAM role are exported

Copy link
Contributor Author

@mmclane mmclane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating to include feedback on making this match the ECS module.

@mmclane
Copy link
Contributor Author

mmclane commented Aug 17, 2023

thanks - we should have exported this from the beginning. Can we copy this https://github.com/terraform-aws-modules/terraform-aws-ecs/blob/f2befd85b08c588ab2df4b515af187d2bb70c9e2/modules/cluster/outputs.tf#L57C1-L70C2 and use it here (update to match the correct name) to ensure the standard properties for the IAM role are exported

I have updated the PR to include role name and unique_id to match what is being done in ECS

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!

@bryantbiggs bryantbiggs merged commit d18ae45 into terraform-aws-modules:master Aug 30, 2023
antonbabenko pushed a commit that referenced this pull request Aug 30, 2023
## [3.1.0](v3.0.0...v3.1.0) (2023-08-30)

### Features

* Add IAM role output ([#22](#22)) ([d18ae45](d18ae45))
@antonbabenko
Copy link
Member

This PR is included in version 3.1.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants