fix: Remove data resource for sns topic to avoid race condition #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bushong1
changed the title
bushong1
changed the title
bushong1
force-pushed
the
fix-sns-topic-data-resource
branch
from
1e8a10f to
3b4c166
Compare
bushong1
changed the title
bushong1
force-pushed
the
fix-sns-topic-data-resource
branch
from
3b4c166 to
d3ba438
Compare
…form-aws-modulesGH-46 Data Resources are evaluated before any code is executed, so if a single terraform apply intends to create an SNS topic _and_ create this module, the apply will fail because the data resource cannot resolve. Avoiding the use of data resources by deriving the SNS manually corrects the issue in this case.
bushong1
force-pushed
the
fix-sns-topic-data-resource
branch
from
d3ba438 to
64d3aa2
Compare
|
This PR works for me. |
|
@antonbabenko Why has this PR not been reviewed? |
Lack of time and various other priorities. Want to support? Consider sponsoring me on GitHub. |
|
Finally! :) v4.12.0 has been just released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the SNS Topic Data Resource and instead craft the SNS Topic ARN as a string.
Motivation and Context
Data Resources are evaluated before any code is executed, so if a single terraform apply intends to create an SNS topic and create this module, the apply will fail because the data resource cannot resolve. Avoiding the use of data resources by deriving the SNS manually corrects the issue in this case.
#46
Breaking Changes
This should not affect any existing deployment aside from seeing a change from removing a data resource.
How Has This Been Tested?
Using the examples