Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for resource tagging #45

Merged

Conversation

jtribble
Copy link
Contributor

@jtribble jtribble commented Nov 4, 2019

Description

The organization I work for requires that we tag all of our AWS resources, so I'd love to get tags wired up for this module! Otherwise, we'll have to fork it 😉

I pretty much just copied what you have here: https://github.com/terraform-aws-modules/terraform-aws-vpc.

@jtribble
Copy link
Contributor Author

jtribble commented Nov 6, 2019

Hey @antonbabenko, no worries if you're too busy to handle this PR right now (I totally get it), but just so you know we're planning on forking the repo if we haven't heard back in the next day or so.

@antonbabenko antonbabenko merged commit 965cac5 into terraform-aws-modules:master Nov 8, 2019
@antonbabenko
Copy link
Member

Good organization you work for, Jeff! ;)

Here we go... v2.1.0 has been just released. Hopefully, you don't mind to use Python 3.7 as runtime (instead of 3.6) which was before.

@jtribble
Copy link
Contributor Author

jtribble commented Nov 8, 2019

@antonbabenko Thank you so much for getting to this!! Python 3.7 is great 😄

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants