feat: Improved AWS backup notification readability

[falense]

Description

When using this module with AWS backup events the resulting message is poorly formatted due to the unstructured nature of the message sent by AWS backup. This PR does a best effort parsing of the message in order to improve readability for the user.

Motivation and Context

Before

After

Breaking Changes

This should not cause any breaking changes and only affects AWS backup messages

How Has This Been Tested?

We have been running on our test environment for a couple of weeks now.

[antonbabenko]

Looks good. Could you please update tests like described here also?

[falense]

I have added a test according to the examples. Did I do it right?

I had some troubles with the somewhat older Python3.8 version so I bumped it to 3.10 to be able to generate the snapshot.

[falense]

I saw that there were more tests. I have corrected the style errors listed below. Is there anything else I can do to get this merged?

./notify_slack.py:290:35: E711 comparison to None should be 'if cond is None:'
./notify_slack.py:298:38: E711 comparison to None should be 'if cond is None:'
./notify_slack.py:307:52: E203 whitespace before ':'

[bryantbiggs]

you'll need to get the CI checks to pass - unfortunately, you have disabled our ability to update your branch so you will have to do these updates on your end

[falense]

Thank you for your reply!

Enabling maintainer edits checkbox is missing on this PR. Not sure if this is a Github issue or if it has to be enabled when creating the PR. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

I have done another iteration on the tests. Please approve the workflows.

[falense]

I have added you both as maintainers on the fork. Maybe that will do the trick?

[antonbabenko]

Maybe, I will take a look in a few hours today.

[falense]

Brainstormed this with some colleagues. Black suggests adding ignoring E203 and E701 as a minimal config. See https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html#minimal-configuration. I have added the change to the PR.

Format adds whitespaces and linting fails because of it. You can try this by running pipenv run format followed by pipenv run lint

[antonbabenko]

I looked at it, but you still need to fix the failing unit tests and formatting to make GitHub Actions green.

[bryantbiggs]

Added in all of the notification examples from here https://docs.aws.amazon.com/aws-backup/latest/devguide/backup-notifications.html to capture in the snapshots. Not sure why the snapshottest library decided to reformat everything - thats rather unfortunate and noisy but all looks good!

cc @antonbabenko

[antonbabenko]

This PR is included in version 6.4.0 🎉

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.