feat: Add SNS topic delivery status IAM role #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Add SNS topic delivery status IAM role * fix: Reference to role local value * fix: Role creation logic
antonbabenko
approved these changes
Oct 21, 2022
Co-authored-by: Anton Babenko <[email protected]>
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Hi, is anything else required from me to merge this? |
antonbabenko
pushed a commit
that referenced
this pull request
Dec 7, 2022
## [5.5.0](v5.4.1...v5.5.0) (2022-12-07) ### Features * Add SNS topic delivery status IAM role ([#178](#178)) ([2863105](2863105))
|
This PR is included in version 5.5.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this pull request is to add delivery status logging for the SNS topic. This is achieved by specifying an IAM role with permission to write to CloudWatch logs. If a role is not specified, then a role will be created - if delivery logging is required.
Motivation and Context
I recently worked on a project which required compliance with NCSC Operational Best Practices. SNS delivery status logging must be enabled to comply with this framework. I created the topic outside of the module initially, but thought it would be a useful addition to the module.
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request