feat: Add variable cluster_primary_security_group_tags for cluster primary security group tags #2586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new input variable
cluster_primary_security_group_tags
to specifically set cluster primary security group tags.Motivation and Context
Alternative to #2249 which was later reverted in #2250.
I am trying to apply AWS provider default tags on Cluster primary security group, I have used
cluster_tags
withdata.aws_default_tags
data source. But this is causing tags changes to be planned/applied every run, because of hashicorp/terraform-provider-aws#18311 and fact thatcluster_tags
is also used inaws_eks_cluster
resource. Using dedicated variable I can do something like:cluster_primary_security_group_tags = data.aws_default_tags.current.tags
instead ofcluster_tags = data.aws_default_tags.current.tags
.Having a dedicated variable also helps in cases where tags on EKS cluster and SG must differ.
Next step would be to remove
var.cluster_tags
from the SG.Breaking Changes
N/A
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request