Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tags seems to be ignored by "aws_eks_node_group" resource #700

Closed
1 of 4 tasks
swapzero opened this issue Jan 20, 2020 · 5 comments
Closed
1 of 4 tasks

tags seems to be ignored by "aws_eks_node_group" resource #700

swapzero opened this issue Jan 20, 2020 · 5 comments

Comments

@swapzero
Copy link

I have issues

I'm submitting a...

  • bug report
  • feature request
  • support request - read the FAQ first!
  • kudos, thank you, warm fuzzy

What is the current behavior?

tags added through additional_tags do not seem to be set

If this is a bug, how to reproduce? Please include a code sample if relevant.

just set this in the nodegroup definition:

additional_tags = {
  TestTag = "blah"
}

terraform apply will show that tags property of aws_eks_node_group resource will be set to {TestTag = "blah"} but it is not listed in the node groups "Tags" tab.

What's the expected behavior?

Tags should be set and yet it does not appear to be a bug in this module.
Do you have any idea of what might be happening?

Are you able to fix this problem and submit a PR? Link here if you have already.

Environment details

  • Affected module version: 8.0.1
  • OS: MacOS Mojave
  • Terraform version:
terraform version
Terraform v0.12.19
+ provider.aws v2.45.0
+ provider.kubernetes v1.10.0
+ provider.local v1.4.0
+ provider.null v2.1.2
+ provider.random v2.2.1
+ provider.template v2.1.2

Any other relevant info

@swapzero
Copy link
Author

This is NOT an issue with the module, what I was expecting was to see the tags propagated to the underlying ASGs created by the node group...

@dpiddockcmp
Copy link
Contributor

Yes, it has been requested in their roadmap aws/containers-roadmap#608

@stale
Copy link

stale bot commented Apr 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 22, 2020
@stale
Copy link

stale bot commented May 22, 2020

This issue has been automatically closed because it has not had recent activity since being marked as stale.

@stale stale bot closed this as completed May 22, 2020
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants