Consider adding more default tags to autoscaled node groups?

[tbarrella]

I'm submitting a...

• bug report
• feature request
• support request
• kudos, thank you, warm fuzzy

What is the current behavior?

Cluster Autoscaler node groups are tagged with "k8s.io/cluster-autoscaler/enabled" (which is helpful)

What's the expected behavior?

It would be helpful if they were also tagged with "k8s.io/cluster-autoscaler/{cluster_name}" as recommended in case you have multiple clusters

It would also be helpful if they were automatically tagged with "k8s.io/cluster-autoscaler/node-template/resource/ephemeral-storage": "{root_volume_size}Gi" to support autoscaling from 0 (see kubernetes/autoscaler#1650)

Are you able to fix this problem and submit a PR? Link here if you have already.

Seems I may be able if people are ok with these being added by default

[brandonjbjelland]

Hola @tbarrella ! 👋

I appreciate the issue you're raising and the links to the docs. I'm onboard with what you're pitching so feel free to start in on the PR at your convenience.

[tbarrella]

Hello, ok cool! Am trying now

[max-rocket-internet]

PR merged. Thanks again 💙

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.