fix: Correct eks_managed_* to self_managed_* for tag_specification argument
#2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Self managed nodes were pulling from the eks_managed_node_group_defaults and not self_managed_node_group_defaults for tag_specifications.
Fix incorrect variable name on self managed nodes
bryantbiggs
changed the title
eks_managed_* to self_managed_* for tag_specification argument
bryantbiggs
changed the title
eks_managed_* to self_managed_* for tag_specification argumenteks_managed_* to self_managed_* for tag_specification argument
antonbabenko
pushed a commit
that referenced
this pull request
Dec 20, 2022
### [19.4.1](v19.4.0...v19.4.1) (2022-12-20) ### Bug Fixes * Correct `eks_managed_*` to `self_managed_*` for `tag_specification` argument ([#2364](#2364)) ([df7c57c](df7c57c))
|
This PR is included in version 19.4.1 🎉 |
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Jan 4, 2023
…on` argument (terraform-aws-modules#2364) Fix incorrect variable name on self managed nodes Self managed nodes were pulling from the eks_managed_node_group_defaults and not self_managed_node_group_defaults for tag_specifications.
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Jan 4, 2023
### [19.4.1](terraform-aws-modules/terraform-aws-eks@v19.4.0...v19.4.1) (2022-12-20) ### Bug Fixes * Correct `eks_managed_*` to `self_managed_*` for `tag_specification` argument ([terraform-aws-modules#2364](terraform-aws-modules#2364)) ([df7c57c](terraform-aws-modules@df7c57c))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix reference for self_manage_node_groups to pull tag_specification from the correct defaults
Motivation and Context
Module was not allowing self managed node group defines to respect tag_specification from self managed node group defaults definition