-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for addon configuration_values
#2345
feat: Add support for addon configuration_values
#2345
Conversation
vpc-cni = {} | ||
coredns = { | ||
configuration_values = jsonencode({ | ||
computeType = "Fargate" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is awesome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi ! Sorry to ask here, but why is this needed ?
(and I agree its awesome)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@auyer until now it was super hard to run this managed addon on fargate since it would default to ec2 and offered no option to change that.
One would have to run complex script to modify the deployment and that would complicate upgrades.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
## [19.1.0](v19.0.4...v19.1.0) (2022-12-16) ### Features * Add support for addon `configuration_values` ([#2345](#2345)) ([3b62f6c](3b62f6c))
This PR is included in version 19.1.0 🎉 |
…ules#2345) Resolves undefined
## [19.1.0](terraform-aws-modules/terraform-aws-eks@v19.0.4...v19.1.0) (2022-12-16) ### Features * Add support for addon `configuration_values` ([terraform-aws-modules#2345](terraform-aws-modules#2345)) ([3b62f6c](terraform-aws-modules@3b62f6c))
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
configuration_values
Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request