Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for addon configuration_values #2345

Merged

Conversation

bryantbiggs
Copy link
Member

Description

  • Add support for addon configuration_values
    • Clean up examples to remove previous hacks for CoreDNS on EKS Fargate using new configuration argument

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

vpc-cni = {}
coredns = {
configuration_values = jsonencode({
computeType = "Fargate"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi ! Sorry to ask here, but why is this needed ?
(and I agree its awesome)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@auyer until now it was super hard to run this managed addon on fargate since it would default to ec2 and offered no option to change that.
One would have to run complex script to modify the deployment and that would complicate upgrades.

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryantbiggs bryantbiggs merged commit 3b62f6c into terraform-aws-modules:master Dec 16, 2022
@bryantbiggs bryantbiggs deleted the feat/addon-configuration branch December 16, 2022 19:44
antonbabenko pushed a commit that referenced this pull request Dec 16, 2022
## [19.1.0](v19.0.4...v19.1.0) (2022-12-16)

### Features

* Add support for addon `configuration_values` ([#2345](#2345)) ([3b62f6c](3b62f6c))
@antonbabenko
Copy link
Member

This PR is included in version 19.1.0 🎉

spr-mweber3 pushed a commit to spring-media/terraform-aws-eks that referenced this pull request Jan 4, 2023
spr-mweber3 pushed a commit to spring-media/terraform-aws-eks that referenced this pull request Jan 4, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add EKS Addon Configurations
4 participants