Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_cloudwatch_event_rule limits cluster name to 35 characters #2311

Closed
FernandoMiguel opened this issue Nov 24, 2022 · 2 comments · Fixed by #2250
Closed

aws_cloudwatch_event_rule limits cluster name to 35 characters #2311

FernandoMiguel opened this issue Nov 24, 2022 · 2 comments · Fixed by #2250

Comments

@FernandoMiguel
Copy link
Contributor

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

  • Yes ✅: please list the AWS provider version which introduced this functionality

Is your request related to a problem? Please describe.

In https://github.com/terraform-aws-modules/terraform-aws-eks/blob/efbe952/modules/karpenter/main.tf#L261
aws_cloudwatch_event_rule name limits cluster name to 35 characters, due to prefixing "Karpenter" and "InstanceStateChange".
Given our clusters have an usually longer name plus append a Random Pet name, this makes it very hard to work with this length limitation

Describe the solution you'd like.

for the use of a different variable for the Queue and the SQS Rule.
Also for the option of using name_prefix

Describe alternatives you've considered.

limiting cluster name to 35 characters until this is addressed

Additional context

The next limit to be hit is aws_sqs_queue name of 80 characters, which is prefixed by Karpenter-, making the total limit for the cluster name of 70 characters.

@antonbabenko
Copy link
Member

This issue has been resolved in version 19.0.0 🎉

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants