fix: Correct variable types to improve dynamic check correctness #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
guess the buttons on mobile don't do the same thing (or what I thought) 😅 |
antonbabenko
pushed a commit
that referenced
this pull request
Jul 1, 2022
### [18.26.2](v18.26.1...v18.26.2) (2022-07-01) ### Bug Fixes * Correct variable types to improve dynamic check correctness ([#2133](#2133)) ([2d7701c](2d7701c))
|
This PR is included in version 18.26.2 🎉 |
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Jul 11, 2022
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Jul 11, 2022
### [18.26.2](terraform-aws-modules/terraform-aws-eks@v18.26.1...v18.26.2) (2022-07-01) ### Bug Fixes * Correct variable types to improve dynamic check correctness ([terraform-aws-modules#2133](terraform-aws-modules#2133)) ([2d7701c](terraform-aws-modules@2d7701c))
baibailiha
added a commit
to baibailiha/terraform-aws-eks
that referenced
this pull request
Sep 13, 2022
### [18.26.2](terraform-aws-modules/terraform-aws-eks@v18.26.1...v18.26.2) (2022-07-01) ### Bug Fixes * Correct variable types to improve dynamic check correctness ([#2133](terraform-aws-modules/terraform-aws-eks#2133)) ([9c16be0](terraform-aws-modules/terraform-aws-eks@9c16be0))
|
This ( |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nulldoesn't appear to work as expected, instead we can compare against number of elementsMotivation and Context
metadata_options, the initial approach would be to setmetadata_options=nullbut this still results in metadata options being set, possibly due to this series within thetry()block. However, if we instead change the type to be a default of{}and check how many elements are within the map, we can now disable the creation ofmetadata_optionsby setting it equal to{}(has to be explicitly set to{}due to default provided from security perspective https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/node_groups.tf#L2)Breaking Changes
nulland the conditional logic updated to supportHow Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request