Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update KMS module version which aligns on module version requirements #2127

Merged

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Jun 28, 2022

Description

  • Update KMS module version which aligns on module version requirements. Version v1.0.1 of the KMS module supports the version of Terraform and AWS provider in this module; in v1.0.0 the versions were Terraform >= 1.0 and AWS provider >= 4.0 which forced users into later version requirements

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs requested a review from antonbabenko June 28, 2022 19:21
@bryantbiggs bryantbiggs merged commit bc04cd3 into terraform-aws-modules:master Jun 29, 2022
@bryantbiggs bryantbiggs deleted the fix/kms-version branch June 29, 2022 11:51
antonbabenko pushed a commit that referenced this pull request Jun 29, 2022
### [18.26.1](v18.26.0...v18.26.1) (2022-06-29)

### Bug Fixes

* Update KMS module version which aligns on module version requirements ([#2127](#2127)) ([bc04cd3](bc04cd3))
@antonbabenko
Copy link
Member

This PR is included in version 18.26.1 🎉

spr-mweber3 pushed a commit to spring-media/terraform-aws-eks that referenced this pull request Jul 11, 2022
spr-mweber3 pushed a commit to spring-media/terraform-aws-eks that referenced this pull request Jul 11, 2022
### [18.26.1](terraform-aws-modules/terraform-aws-eks@v18.26.0...v18.26.1) (2022-06-29)

### Bug Fixes

* Update KMS module version which aligns on module version requirements ([terraform-aws-modules#2127](terraform-aws-modules#2127)) ([bc04cd3](terraform-aws-modules@bc04cd3))
baibailiha added a commit to baibailiha/terraform-aws-eks that referenced this pull request Sep 13, 2022
### [18.26.1](terraform-aws-modules/terraform-aws-eks@v18.26.0...v18.26.1) (2022-06-29)

### Bug Fixes

* Update KMS module version which aligns on module version requirements ([#2127](terraform-aws-modules/terraform-aws-eks#2127)) ([3e01815](terraform-aws-modules/terraform-aws-eks@3e01815))
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dependency should be to kms 1.0.1 - not 1.0.0 Terraform init failing for terraform version < 1.X
2 participants