feat: Allow users to selectively attach the EKS created cluster primary security group to nodes #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry security group to nodes
1 task
|
@antonbabenko if you get some time, this one should be ready to go |
antonbabenko
pushed a commit
that referenced
this pull request
Mar 23, 2022
## [18.13.0](v18.12.0...v18.13.0) (2022-03-23) ### Features * Allow users to selectively attach the EKS created cluster primary security group to nodes ([#1952](#1952)) ([e21db83](e21db83))
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Apr 26, 2022
…ry security group to nodes (terraform-aws-modules#1952)
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Apr 26, 2022
## [18.13.0](terraform-aws-modules/terraform-aws-eks@v18.12.0...v18.13.0) (2022-03-23) ### Features * Allow users to selectively attach the EKS created cluster primary security group to nodes ([terraform-aws-modules#1952](terraform-aws-modules#1952)) ([e21db83](terraform-aws-modules@e21db83))
it-without-politics
pushed a commit
to it-without-politics/terraform-aws-eks
that referenced
this pull request
May 23, 2022
…ry security group to nodes (terraform-aws-modules#1952)
it-without-politics
pushed a commit
to it-without-politics/terraform-aws-eks
that referenced
this pull request
May 23, 2022
## [18.13.0](terraform-aws-modules/terraform-aws-eks@v18.12.0...v18.13.0) (2022-03-23) ### Features * Allow users to selectively attach the EKS created cluster primary security group to nodes ([terraform-aws-modules#1952](terraform-aws-modules#1952)) ([e21db83](terraform-aws-modules@e21db83))
1 task
baibailiha
added a commit
to baibailiha/terraform-aws-eks
that referenced
this pull request
Sep 13, 2022
## [18.13.0](terraform-aws-modules/terraform-aws-eks@v18.12.0...v18.13.0) (2022-03-23) ### Features * Allow users to selectively attach the EKS created cluster primary security group to nodes ([#1952](terraform-aws-modules/terraform-aws-eks#1952)) ([106dba0](terraform-aws-modules/terraform-aws-eks@106dba0))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
attach_cluster_primary_security_groupto EKS managed node group and self managed node group root module definitions. When set totrue, the security group that is automatically created by the EKS control plane is passed to the node group sub-module where it is included in the launch template for nodes to utilize when launched via the addedcluster_primary_security_group_idvariable (note - no changes to Fargate profiles since they use this by default and the API currently doesn't allow for managing profile security groups)completeexample to demonstrate as well as security group section of docsMotivation and Context
Breaking Changes
How Has This Been Tested?
examples/*projectscompleteexample