Support default_tags in aws_autoscaling_group

[caleb-devops]

Is your request related to a problem? Please describe.

Tags created in the default_tags block in the AWS provider are not applied to aws_autoscaling_group.

Describe the solution you'd like.

Apply default_tags to the aws_autoscaling_group in the self-managed-node-group module.

Additional context

https://learn.hashicorp.com/tutorials/terraform/aws-default-tags?in=terraform/aws#propagate-default-tags-to-auto-scaling-group

[kishore-kumar-ripcord]

I agree, plus this is needed for EKS managed node group as well without using custom launch template.

[bryantbiggs]

I agree, plus this is needed for EKS managed node group as well without using custom launch template.

Thats not possible unless AWS supports it in the API

[thecosmicfrog]

@bryantbiggs I'm beginning the migration from v17 to v18 at the moment. I believe I'm right in saying create_launch_template = false is required to support using disk_size = N in eks_managed_node_group_defaults{}, correct?

This works fine, but this first thing I noticed is that tags are no longer propagated to the EC2 instances (so all instances have "blank" names in the console).

So, is the only solution to this is to manage our own launch template? Thanks.

[antonbabenko]

This issue has been resolved in version 18.16.0 🎉

[stevo-f3]

Would it make sense to support same for:

• aws_launch_template's tag_specifications https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/modules/self-managed-node-group/main.tf#L233-L239
• cluster_primary_security_group aws_ec2_tags https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/main.tf#L69

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.