Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use the prefix_seperator var for node sg prefix #1751

Merged
merged 1 commit into from
Jan 8, 2022
Merged

fix: Use the prefix_seperator var for node sg prefix #1751

merged 1 commit into from
Jan 8, 2022

Conversation

martijnvdp
Copy link
Contributor

@martijnvdp martijnvdp commented Jan 7, 2022

Description

Use var.prefix_separator for the node security group prefix like in the cluster security group prefix

Motivation and Context

so it is consistent with the cluster security group

Breaking Changes

no

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

@martijnvdp martijnvdp changed the title use the prefix_seperator var for node sg prefix fix: use the prefix_seperator var for node sg prefix Jan 7, 2022
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonbabenko 👍🏽

@martijnvdp martijnvdp changed the title fix: use the prefix_seperator var for node sg prefix Fix: use the prefix_seperator var for node sg prefix Jan 7, 2022
@martijnvdp martijnvdp changed the title Fix: use the prefix_seperator var for node sg prefix fix: Use the prefix_seperator var for node sg prefix Jan 7, 2022
@antonbabenko antonbabenko merged commit 62879dd into terraform-aws-modules:master Jan 8, 2022
antonbabenko pushed a commit that referenced this pull request Jan 8, 2022
### [18.0.5](v18.0.4...v18.0.5) (2022-01-08)

### Bug Fixes

* Use the prefix_seperator var for node sg prefix ([#1751](#1751)) ([62879dd](62879dd))
@antonbabenko
Copy link
Member

This PR is included in version 18.0.5 🎉

@martijnvdp martijnvdp deleted the prefix_separator-node-sg branch January 8, 2022 20:52
baibailiha added a commit to baibailiha/terraform-aws-eks that referenced this pull request Sep 13, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants