Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubelet_extra_args cannot be specified in bootstrap_env #1724

Closed
mustafa89 opened this issue Dec 20, 2021 · 3 comments · Fixed by #1680
Closed

kubelet_extra_args cannot be specified in bootstrap_env #1724

mustafa89 opened this issue Dec 20, 2021 · 3 comments · Fixed by #1680

Comments

@mustafa89
Copy link

mustafa89 commented Dec 20, 2021

Description

I've been trying to use the KUBELET_EXTRA_ARGS in the bootstrap_env map in order to set taints but it was not working. After some digging I see that the default user_data always sets this value therefore the exported env var is never read.

SEE:

/etc/eks/bootstrap.sh ${cluster_name} --kubelet-extra-args <node-lables + taints + default labels> --apiserver-endpoint "$${API_SERVER_URL}" --b64-cluster-ca "$${B64_CLUSTER_CA}"

I think this should be mentioned in the README or Input descriptions. Currently, it implies all arguments to the bootstrap.sh script can be defined within in the bootstrap_env map.

⚠️ Note

Not using a custom AMI.

Versions

  • Terraform: 0.13.6
  • Provider(s): AWS: 3.63.0
  • Module: 17.23.0

Reproduction

Add the below bootstrap_env key-value to a node group definition. The value will not be propagated.

Code Snippet to Reproduce

bootstrap_env = {
          KUBELET_EXTRA_ARGS = "--register-with-taints=dedicated=TEST:NoSchedule"
}

Expected behavior

AFAIS, KUBELET_EXTRA_ARGS is not supported in bootstrap_env

@mustafa89
Copy link
Author

mustafa89 commented Dec 21, 2021

luckily stumbled upon: #1717 (comment)

I feel this point # 1 should really be mentioned in the docs some where.

@antonbabenko
Copy link
Member

This issue has been resolved in version 18.0.0 🎉

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants