Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support instance weights for override_instance_types #1720

Closed
ghost opened this issue Dec 17, 2021 · 2 comments · Fixed by #1680
Closed

Support instance weights for override_instance_types #1720

ghost opened this issue Dec 17, 2021 · 2 comments · Fixed by #1680

Comments

@ghost
Copy link

ghost commented Dec 17, 2021

It would be great when using an ASG with multiple instance types, to be able to specify weights, something like:

override_instance_types = [
        {
          instance_type     = "t3a.xlarge"
          weighted_capacity = 4
        },
        {
          instance_type     = "t3.xlarge"
          weighted_capacity = 4
        },
        {
          instance_type     = "t3a.large"
          weighted_capacity = 2
        },
        {
          instance_type     = "t3.large"
          weighted_capacity = 2
        },
      ]

But this seems impossible due to https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/workers_launch_template.tf#L168

https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/docs/spot-instances.md#using-launch-templates-with-both-spot-and-on-demand mentions "(first in the array if they are not weighted)." but I do not see how to weight them.

Cheers!

@antonbabenko
Copy link
Member

This issue has been resolved in version 18.0.0 🎉

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant