Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify managed nodegroups launch template template tags_specifications #1689

Closed
YakobovLior opened this issue Nov 10, 2021 · 5 comments · Fixed by #1680
Closed

Modify managed nodegroups launch template template tags_specifications #1689

YakobovLior opened this issue Nov 10, 2021 · 5 comments · Fixed by #1680

Comments

@YakobovLior
Copy link

Versions

  • Terragrunt: v0.31.0
  • Terraform: v1.0.2

Description

I'm looking for the ability to configure tags_specifications for the created launch template, without the need to create a dedicated launch template in advance.

module "eks" {
  source          = "terraform-aws-modules/eks/aws"
  cluster_name    = "${local.envname}-eks-cluster"
  cluster_version = "1.21"
  vpc_id  = var.vpc_id
  subnets = var.private_subnet_ids  

  cluster_create_timeout                         = "1h"
  cluster_endpoint_private_access                = true
  cluster_endpoint_public_access                 = true
  cluster_create_endpoint_private_access_sg_rule = true
  cluster_endpoint_private_access_cidrs          = var.ingress_cidr_blocks

  node_groups_defaults = {
    ami_type  = "AL2_x86_64"
    subnets   = ["subnet-0825..."]
  }

  node_groups = {
    # Nodegroup for main pods (jenkins master, gitlab services, etc)
    gnrl = {
      desired_capacity = 2
      min_capacity     = 2
      max_capacity     = 2

      instance_types = [var.instance_type_main_ng]
      capacity_type = "ON_DEMAND"
      disk_size     = var.disk_size_main_ng
      k8s_labels = {
        Environment = var.environment
        "node-role.eks.io/main" = "true"
      }
    }

    # Nodegroup for jenkins workers pods
    jwork = {
      desired_capacity = 2
      min_capacity     = 2
      max_capacity     = 10

      instance_types = [var.instance_type_jenkins_workers_ng]
      capacity_type = "SPOT"
      disk_size     = var.disk_size_jenkins_workers_ng
      k8s_labels = {
        Environment = var.environment
        "node-role.eks.io/jenkins-workers" = "true"
      }
    }
  }

Eventually, 2 nodegroups have been created but since there is no template tags with key Name,

Screen Shot 2021-11-10 at 17 11 56

My instances are being created with any names at all:

Screen Shot 2021-11-10 at 17 12 21

Is there a way to achieve my goal?
Thanks,

Lior

@daroga0002
Copy link
Contributor

daroga0002 commented Nov 10, 2021

Is there a way to achieve my goal?

not by this module as AWS EKS node group API doesnt provide such option for pure node groups

@github-actions
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Dec 11, 2021
@github-actions
Copy link

This issue was automatically closed because of stale in 10 days

@antonbabenko
Copy link
Member

This issue has been resolved in version 18.0.0 🎉

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants