feat: Add metadata_options for node_groups #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbrunet
force-pushed
the
feature/node_groups/lt-metadata-options
branch
from
2862deb to
0873af5
Compare
1 task
maxbrunet
force-pushed
the
feature/node_groups/lt-metadata-options
branch
2 times, most recently
from
7698abf to
7531c18
Compare
1 task
|
@maxbrunet are you planning to rebase again? |
maxbrunet
force-pushed
the
feature/node_groups/lt-metadata-options
branch
from
7531c18 to
99b69ae
Compare
|
@maxbrunet Please rebase and I will merge it right away. Sorry that this one take so long, too. |
maxbrunet
force-pushed
the
feature/node_groups/lt-metadata-options
branch
from
99b69ae to
fe14810
Compare
|
Rebased. Thank you @antonbabenko! |
|
Here it is! Thanks, @maxbrunet and @xr0n1ck for the work and lengthy discussion. v17.18.0 has been just released. 🚀 |
1 task
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR o'clock
Description
Add
metadata_optionsin customlaunch_templatefor managed node groups.Useful for: https://docs.aws.amazon.com/eks/latest/userguide/best-practices-security.html
Checklist