Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix AMI filtering when the default platform is provided in var.workers_group_defaults #1413

Merged
merged 2 commits into from
May 28, 2021

Conversation

barryib
Copy link
Member

@barryib barryib commented May 28, 2021

PR o'clock

Description

Supersedes #1411

Resolves #1410

Checklist

@brettcave
Copy link

@barryib - Apply complete! - have deployed with Windows platform with this, confirming it works.

@barryib barryib merged commit f993c36 into terraform-aws-modules:master May 28, 2021
@barryib barryib deleted the fix-1410 branch May 28, 2021 20:12
@barryib
Copy link
Member Author

barryib commented May 28, 2021

Thanks @brettcave your help.

@barryib
Copy link
Member Author

barryib commented May 28, 2021

v17.0.3 is released

ArchiFleKs pushed a commit to ArchiFleKs/terraform-aws-eks that referenced this pull request Jun 1, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows platform will always fail, because "windows" != "linux"
2 participants