Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GP3 volume type #1130

Closed
1 task done
sgran opened this issue Dec 2, 2020 · 4 comments · Fixed by #1146
Closed
1 task done

Support GP3 volume type #1130

sgran opened this issue Dec 2, 2020 · 4 comments · Fixed by #1146

Comments

@sgran
Copy link

sgran commented Dec 2, 2020

Support GP3 volume type

I'm submitting a...

  • feature request

What is the current behavior?

root_volume_type and a few other configuration parameters affect the sort of EBS volume selected for the root volume for worker nodes. AWS introduced a new volume type, GP3. This new volume type needs a new parameter on the EBS section of the launch configuration, 'throughput'. This new parameter is only valid for GP3 configurations and has a default value of 125.

This will almost certainly have to block on the AWS provider getting support for the new volume type and changing the struct for the EBS volume.

@jayzalowitz
Copy link
Contributor

jayzalowitz commented Dec 3, 2020

Yep I tested a deploy and its blocked on validation to even change it to gp3: hashicorp/terraform-provider-aws#16514

@sidprak
Copy link
Contributor

sidprak commented Dec 14, 2020

Now that provider support has landed in the launch template resource, I tested this out and gp3 volumes seem to work out of the box with this module. As mentioned above, the throughput setting needs to be added which I've done in #1146.

@sidprak
Copy link
Contributor

sidprak commented Dec 14, 2020

Doing some googling, looks like gp3 is not supported in launch configuration yet (maybe not going to be supported at all?) so the support in #1146 is only in launch templates.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants