Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document differences between (var.worker_groups, var.worker_groups_launch_template) Workers Groups and (var.node_groups) Managed Node Groups #1077

Closed
mmgari opened this issue Oct 29, 2020 · 9 comments

Comments

@mmgari
Copy link

mmgari commented Oct 29, 2020

Whats the difference between Workers and Nodes?

First, my apologies if this is not the place for these kind of questions.

I was wondering if anyone can point me some basic differences between Worker groups and Node groups. If I create a node group, I am able to see it from the AWS console in the "compute" section of the cluster. But if I create a worker-group, I only see it if I query the cluster with kubectl get nodes.

Thanks!

@fcervantes2
Copy link

worker_nodes are "self-managed" node groups, while node_groups are AWS-managed node-groups. It would be nice to have a renaming of these variables to make the distinction a bit more clearer. For more info, I suggest you look at the official docs: https://docs.aws.amazon.com/eks/latest/userguide/eks-compute.html

@mmgari
Copy link
Author

mmgari commented Nov 2, 2020

Thank you! Cristal clear.

@dzirg44
Copy link

dzirg44 commented Nov 2, 2020

Also it would be fair to mention that node_groups don't allow you to use spot instances.

@barryib
Copy link
Member

barryib commented Nov 2, 2020

Can someone update the FAQ to explain this difference please ?

@jeff-knurek
Copy link

This is a duplicate of #895
but this module does need some better documentation (FAQ update?) so it doesn't continue to keep getting asked.

@barryib barryib changed the title Worker vs Nodes Document differences between (var.worker_groups, var.worker_groups_launch_template) Workers Groups and (var.node_groups) Managed Node Groups Nov 3, 2020
@barryib
Copy link
Member

barryib commented Nov 3, 2020

This is a duplicate of #895
but this module does need some better documentation (FAQ update?) so it doesn't continue to keep getting asked.

Yep. I'll happy to review and merge the PR.

Sure, I can write something up when I find free time.

Maybe @pranas #895 (comment) ?

@pranas
Copy link
Contributor

pranas commented Nov 3, 2020

Sorry, I lost track of this promise. I'm gonna do it right now and open PR so everyone can pitch in on what exactly should be there.

@barryib
Copy link
Member

barryib commented Nov 3, 2020

Closing this since #1081 is now merged.

@barryib barryib closed this as completed Nov 3, 2020
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants