Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow for both Fargate and EC2/Autoscaling capacity providers in same cluster #69

Merged
merged 1 commit into from
Jul 25, 2022
Merged

fix: Allow for both Fargate and EC2/Autoscaling capacity providers in same cluster #69

merged 1 commit into from
Jul 25, 2022

Conversation

bryantbiggs
Copy link
Member

Description

  • Allow for both Fargate and EC2/Autoscaling capacity providers in same cluster

Motivation and Context

Breaking Changes

  • No; if users are currently using EC2/Autoscaling as their default capacity provider strategy, they will want to set default_capacity_provider_use_fargate = false

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs requested a review from antonbabenko July 25, 2022 17:27
antonbabenko
antonbabenko reviewed Jul 25, 2022
View reviewed changes
main.tf Show resolved Hide resolved
antonbabenko
antonbabenko approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryantbiggs bryantbiggs merged commit 9cb2b84 into terraform-aws-modules:master Jul 25, 2022
@bryantbiggs bryantbiggs deleted the fix/mixed-cluster-support branch July 25, 2022 19:03
antonbabenko pushed a commit that referenced this pull request Jul 25, 2022
@semantic-release-bot
chore(release): version 4.1.1 [skip ci]
e2304e2 
### [4.1.1](v4.1.0...v4.1.1) (2022-07-25)

### Bug Fixes

* Allow for both Fargate and EC2/Autoscaling capacity providers in same cluster ([#69](#69)) ([9cb2b84](9cb2b84))
@antonbabenko
Copy link
Member

This PR is included in version 4.1.1 🎉

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mixing ASG and Fargate capacity providers does not work
2 participants
@bryantbiggs @antonbabenko