Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Export cluster name since cluster ID is exporting the ARN #67

Merged

Conversation

bryantbiggs
Copy link
Member

Description

  • Export cluster name since cluster ID is exporting the ARN

Motivation and Context

  • When integrating with other services, the cluster name is required for some inputs. However, the cluster ID is currently the cluster ARN as opposed to other places where IDs are typically a unique ID or the resource name. The name output is necessary to map dependencies correctly

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs requested a review from antonbabenko June 29, 2022 14:07
bryantbiggs referenced this pull request in aws-ia/ecs-blueprints Jun 29, 2022
@antonbabenko antonbabenko merged commit 8c9273f into terraform-aws-modules:master Jun 29, 2022
@bryantbiggs bryantbiggs deleted the feat/export-name branch June 29, 2022 14:56
@bryantbiggs
Copy link
Member Author

release is most likely waiting for GitHub issues to resolve

image

antonbabenko pushed a commit that referenced this pull request Jun 29, 2022
## [4.1.0](v4.0.2...v4.1.0) (2022-06-29)

### Features

* Export cluster name since cluster ID is exporting the ARN ([#67](#67)) ([8c9273f](8c9273f))
@antonbabenko
Copy link
Member

This PR is included in version 4.1.0 🎉

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants