Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add aws to required providers #181

Merged

Conversation

jasondamour
Copy link
Contributor

Description

Add AWS provider to required_providers, omitting the version since that's inherited from child modules

Motivation and Context

#180

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@jasondamour jasondamour changed the title chore: add aws to required providers chore: Add aws to required providers Mar 19, 2024
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonbabenko antonbabenko changed the title chore: Add aws to required providers fix: Add aws to required providers Mar 27, 2024
@jasondamour
Copy link
Contributor Author

Done @antonbabenko

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@antonbabenko antonbabenko merged commit 59fd4fa into terraform-aws-modules:master Apr 10, 2024
11 checks passed
antonbabenko pushed a commit that referenced this pull request Apr 10, 2024
## [5.11.1](v5.11.0...v5.11.1) (2024-04-10)

### Bug Fixes

* Add aws to required providers ([#181](#181)) ([59fd4fa](59fd4fa))
@antonbabenko
Copy link
Member

This PR is included in version 5.11.1 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants