Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use cloudwatch group in several environments. #113

Closed
bohdantverdyi opened this issue Sep 13, 2023 · 6 comments · Fixed by #126
Closed

Unable to use cloudwatch group in several environments. #113

bohdantverdyi opened this issue Sep 13, 2023 · 6 comments · Fixed by #126

Comments

@bohdantverdyi
Copy link

name = "/aws/ecs/${var.service}/${var.name}"

Since the service name could be the same across environments, it can cause conflicts when a CloudWatch group already exists while applying to another environment.

If I add the option to logDriver: awslogs-create-group = true, then I can't specify the retention size.

The only way to achieve this is to create a CloudWatch group outside of this module.
It would be great if the module could support a variable override for the CloudWatch group name.

@bryantbiggs
Copy link
Member

Since the service name could be the same across environments, it can cause conflicts when a CloudWatch group already exists while applying to another environment.

What does this mean?

@bohdantverdyi
Copy link
Author

I have two clusters: 'stage' and 'prod.' Both of them have an 'api' service, and the service name is the same in both the stage and prod clusters.

Cloudwatch group created by module will have attempt to create cloudwatch group with the same.

@github-actions
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Oct 14, 2023
@bohdantverdyi
Copy link
Author

Remove stale

@antonbabenko
Copy link
Member

This issue has been resolved in version 5.3.0 🎉

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants