Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add note in README about CloudFront with ACM #79

Merged
merged 3 commits into from
Jun 28, 2021

Conversation

yuklia
Copy link
Contributor

@yuklia yuklia commented Mar 29, 2021

Description

I've updated README with an example of usage CloudFront + ACM. I think it is not obvious that CloudFront works only with the us-east-1 region. Hope it will help :)

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! LGTM :)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@antonbabenko antonbabenko changed the title 📝 Update README.md: Add example for CloudFront + ACM docs: Add note in README for CloudFront with ACM Jun 28, 2021
@antonbabenko antonbabenko changed the title docs: Add note in README for CloudFront with ACM docs: Add note in README about CloudFront with ACM Jun 28, 2021
@antonbabenko antonbabenko merged commit ed37744 into terraform-aws-modules:master Jun 28, 2021
@antonbabenko
Copy link
Member

v3.2.0 has been just released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants